GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/skylake: Switch FADT to ACPI version 3.0 

On Apollo Lake it was discovered that our current FADT implementation is
valid for ACPI version 3.0 but misses fields for ACPI version 5.0. We
run into booting issues with Windows 10 using version 5 in the FADT
header. In commit 2b8552f49bc3a7d0290f96a84b573669de396011
(intel/apollolake: Switch FADT to ACPI version 3.0) we go back to
version 3 for Apollo Lake. Skylake is now the last platform that uses
version 5 in FADT header.

Change-Id: I2d0367fae5321dee4ccac417b7f99466f8973577
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/19453
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Werner Zeh 2017-04-26 07:03:10 +02:00
parent 27e6042bb7
commit 00d250e228
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/skylake/acpi.c
View File

@ -226,8 +226,8 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC); const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC);
config_t *config = dev->chip_info; config_t *config = dev->chip_info;
/* Use ACPI 5.0 revision */ /* Use ACPI 3.0 revision */
fadt->header.revision = ACPI_FADT_REV_ACPI_5_0; fadt->header.revision = ACPI_FADT_REV_ACPI_3_0;
fadt->sci_int = acpi_sci_irq(); fadt->sci_int = acpi_sci_irq();
fadt->smi_cmd = APM_CNT; fadt->smi_cmd = APM_CNT;