GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/cpu/svi2: drop unneeded core_vid check 

A core voltage ID larger than 0xff shouldn't happen, since SVI2's core
VID is only 8 bit long. In order for making it more difficult to use
this function in a wrong way that results in a very wrong voltage being
returned, also return 0 for those invalid core VID values.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I95417c45db86cd2373879cdad8a07fb9eb8dfdda
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74000
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2023-03-24 00:25:39 +01:00
parent 509321f5a8
commit 00d496f92f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/cpu/svi2.c
View File

@ -10,8 +10,8 @@
uint32_t get_uvolts_from_vid(uint16_t core_vid) uint32_t get_uvolts_from_vid(uint16_t core_vid)
{ {
if ((core_vid >= 0xF8) && (core_vid <= 0xFF)) { if (core_vid >= 0xF8) {
/* Voltage off for VID codes 0xF8 to 0xFF */ /* Voltage off for VID codes >= 0xF8 */
return 0; return 0;
} else { } else {
return SERIAL_VID_2_MAX_MICROVOLTS - return SERIAL_VID_2_MAX_MICROVOLTS -