GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: mark .textfirst as allocatable and executable 

When the linking of ramstage was changed to use an intermeidate
object with all ramstage objects in it the .textfirst section
was introduced to keep the entry point at 0. However, the
section was not marked allocatable or executable. Nor was it
marked as @progbits. That didn't cause an issue on its own since
.textfirst was directly called out in the linker script. However,
the rmodule infrastructure relies on all the relocation entries
being included in the rmodule. Without the proper section attributes
the .rel.textfirst section entries were not being included in
the final ramstage rmodule.

Change-Id: I54e7055a19bee6c86e269eba047d9a560702afde
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/2885
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Aaron Durbin 2013-03-22 20:23:17 -05:00 committed by Stefan Reinauer
parent b467f1ddaf
commit 0135702802
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/arch/x86/lib/c_start.S
View File

@ -11,7 +11,7 @@ _stack:
.space CONFIG_MAX_CPUS*CONFIG_STACK_SIZE .space CONFIG_MAX_CPUS*CONFIG_STACK_SIZE
_estack: _estack:
.section ".textfirst" .section ".textfirst", "ax", @progbits
.code32 .code32
.globl _start .globl _start
_start: _start: