From 0151b463c3a29db731c8d2c2f5f07d7b73082a97 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 23 Feb 2021 17:08:44 +0100 Subject: [PATCH] soc/amd/picasso/data_fabric: add missing data fabric device function 7 The device function is missing in the PCI device table in the PPR, but is present in the hardware. Verified on a Mandolin board with PCO APU. The corresponding ticket for the PPR is DESPCSOC-6667. Signed-off-by: Felix Held Change-Id: Ie91438bc905691d443ca4e7841549d1e3bca39ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/51041 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson --- src/include/device/pci_ids.h | 1 + src/soc/amd/picasso/data_fabric.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index d6e0ee7a05..475d0a84c8 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -475,6 +475,7 @@ #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4 0x15EC #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5 0x15ED #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6 0x15EE +#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7 0x15EF #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF0 0x1448 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF1 0x1449 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF2 0x144A diff --git a/src/soc/amd/picasso/data_fabric.c b/src/soc/amd/picasso/data_fabric.c index 982b7b243d..700cb84d6b 100644 --- a/src/soc/amd/picasso/data_fabric.c +++ b/src/soc/amd/picasso/data_fabric.c @@ -115,6 +115,8 @@ static const char *data_fabric_acpi_name(const struct device *dev) return "DFD5"; case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6: return "DFD6"; + case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7: + return "DFD7"; default: printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device); } @@ -137,6 +139,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6, + PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7, 0 };