GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer: Change default camera power GPIO to 0 

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be just a blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang <daniel.h.kang@intel.com>
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45058
Reviewed-by: Caveh Jalali <caveh@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Daniel Kang 2020-09-02 19:43:04 -07:00 committed by Tim Wawrzynczak
parent 9f963d3325
commit 029069960e
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/volteer/variants/volteer/gpio.c
View File

@ -93,9 +93,9 @@ static const struct pad_config override_gpio_table[] = {
/* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
PAD_NC(GPP_D16, UP_20K), PAD_NC(GPP_D16, UP_20K),
/* D17 : ISH_GP4 ==> EN_FCAM_PWR */ /* D17 : ISH_GP4 ==> EN_FCAM_PWR */
PAD_CFG_GPO(GPP_D17, 1, DEEP), PAD_CFG_GPO(GPP_D17, 0, DEEP),
/* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */ /* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */
PAD_CFG_GPO(GPP_D18, 1, DEEP), PAD_CFG_GPO(GPP_D18, 0, DEEP),
/* E1 : SPI1_IO2 ==> PEN_DET_ODL */ /* E1 : SPI1_IO2 ==> PEN_DET_ODL */
PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE), PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE),
@ -154,7 +154,7 @@ static const struct pad_config override_gpio_table[] = {
/* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */ /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */
PAD_CFG_GPI(GPP_H13, NONE, DEEP), PAD_CFG_GPI(GPP_H13, NONE, DEEP),
/* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */ /* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */
PAD_CFG_GPO(GPP_H14, 1, DEEP), PAD_CFG_GPO(GPP_H14, 0, DEEP),
/* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */ /* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */
PAD_CFG_GPI(GPP_H15, NONE, DEEP), PAD_CFG_GPI(GPP_H15, NONE, DEEP),
/* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */ /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */
@ -164,7 +164,7 @@ static const struct pad_config override_gpio_table[] = {
/* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */ /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */
PAD_CFG_GPI(GPP_H19, NONE, DEEP), PAD_CFG_GPI(GPP_H19, NONE, DEEP),
/* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */ /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */
PAD_CFG_GPO(GPP_H20, 1, DEEP), PAD_CFG_GPO(GPP_H20, 0, DEEP),
/* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */ /* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */
PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
/* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */ /* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */

8
src/mainboard/google/volteer/variants/volteer2/gpio.c
View File

@ -93,9 +93,9 @@ static const struct pad_config override_gpio_table[] = {
/* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
PAD_NC(GPP_D16, UP_20K), PAD_NC(GPP_D16, UP_20K),
/* D17 : ISH_GP4 ==> EN_FCAM_PWR */ /* D17 : ISH_GP4 ==> EN_FCAM_PWR */
PAD_CFG_GPO(GPP_D17, 1, DEEP), PAD_CFG_GPO(GPP_D17, 0, DEEP),
/* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */ /* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */
PAD_CFG_GPO(GPP_D18, 1, DEEP), PAD_CFG_GPO(GPP_D18, 0, DEEP),
/* E1 : SPI1_IO2 ==> PEN_DET_ODL */ /* E1 : SPI1_IO2 ==> PEN_DET_ODL */
PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE), PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE),
@ -154,7 +154,7 @@ static const struct pad_config override_gpio_table[] = {
/* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */ /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */
PAD_CFG_GPI(GPP_H13, NONE, DEEP), PAD_CFG_GPI(GPP_H13, NONE, DEEP),
/* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */ /* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */
PAD_CFG_GPO(GPP_H14, 1, DEEP), PAD_CFG_GPO(GPP_H14, 0, DEEP),
/* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */ /* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */
PAD_CFG_GPI(GPP_H15, NONE, DEEP), PAD_CFG_GPI(GPP_H15, NONE, DEEP),
/* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */ /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */
@ -164,7 +164,7 @@ static const struct pad_config override_gpio_table[] = {
/* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */ /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */
PAD_CFG_GPI(GPP_H19, NONE, DEEP), PAD_CFG_GPI(GPP_H19, NONE, DEEP),
/* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */ /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */
PAD_CFG_GPO(GPP_H20, 1, DEEP), PAD_CFG_GPO(GPP_H20, 0, DEEP),
/* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */ /* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */
PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
/* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */ /* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */