GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tigerlake: fix call to print_spd_info() 

Pointer passed to print_spd_info() from meminit.c needs to be
dereferenced first, so this change dereferences it.

BUG=b:154352883
TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot
volteer, login to kernel and execute the following cbmem command:
  localhost ~ # cbmem -c | grep LPDDR4X
and verify it returns "SPD: module type is LPDDR4X"

Change-Id: I5ff64121f0d50947c4946e9e02460dfb7319d01a
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
Nick Vaccaro 2020-04-17 13:38:10 -07:00
parent f0ebaf2260
commit 029b5432a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/tigerlake/meminit.c
View File

@ -230,7 +230,7 @@ static void read_md_spd(const struct spd_info *info, uintptr_t *data, size_t *le
die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc); die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc);
} }
print_spd_info((unsigned char *)data); print_spd_info((uint8_t *) *data);
} }
void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg, void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg,
@ -317,7 +317,7 @@ static void read_sodimm_spd(const struct spd_info *info, struct spd_block *blk)
for (i = 0; i < ARRAY_SIZE(blk->addr_map); i++) { for (i = 0; i < ARRAY_SIZE(blk->addr_map); i++) {
if (blk->addr_map[i]) if (blk->addr_map[i])
print_spd_info((unsigned char *)blk->spd_array[i]); print_spd_info((uint8_t *)blk->spd_array[i]);
} }
} }