GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tree: Replace ShiftRight(a,b,c) with ASL 2.0 syntax

Browse source 
Replace `ShiftRight (a, b, c)` with `c = a >> b`. One case was
simplified to just `a >> b`.

Change-Id: I889012b0a3067138e6f02d3fe8e97151effb5c2a
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70840
Reviewed-by: Caveh Jalali <caveh@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Felix Singer 2022-12-16 02:25:30 +01:00
parent 100f92c54f
commit 034920c1d4
7 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ec/google/chromeec/acpi/battery.asl
View file

@ -209,7 +209,7 @@ Method (BBST, 4, Serialized)
Local2 = BTDF Local2 = BTDF
// See if within ~6% of full // See if within ~6% of full
ShiftRight (Local2, 4, Local3) Local3 = Local2 >> 4
If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3)
{ {
Local1 = Local2 Local1 = Local2

10
src/ec/lenovo/h8/acpi/thinkpad.asl
View file

@ -184,9 +184,9 @@ Device (HKEY)
HAST = One HAST = One
If (HBDC) { If (HBDC) {
ShiftRight (Arg0 & 2, 1, Local0) Local0 = (Arg0 & 2) >> 1
\_SB.PCI0.LPCB.EC.BTEB = Local0 \_SB.PCI0.LPCB.EC.BTEB = Local0
ShiftRight (Arg0 & 4, 2, Local0) Local0 = (Arg0 & 4) >> 2
WBDC = Local0 WBDC = Local0
} }
} }
@ -226,9 +226,9 @@ Device (HKEY)
HAST = One HAST = One
If (HWAN) { If (HWAN) {
ShiftRight (Arg0 & 2, 1, Local0) Local0 = (Arg0 & 2) >> 1
\_SB.PCI0.LPCB.EC.WWEB = Local0 \_SB.PCI0.LPCB.EC.WWEB = Local0
ShiftRight (Arg0 & 4, 2, WWAN) WWAN = (Arg0 & 4) >> 2
} }
} }
@ -288,7 +288,7 @@ Device (HKEY)
Method (SUWB, 1) Method (SUWB, 1)
{ {
If (HUWB) { If (HUWB) {
ShiftRight (Arg0 & 2, 1, Local0) Local0 = (Arg0 & 2) >> 1
\_SB.PCI0.LPCB.EC.UWBE = Local0 \_SB.PCI0.LPCB.EC.UWBE = Local0
} }
} }

2
src/ec/quanta/it8518/acpi/battery.asl
View file

@ -316,7 +316,7 @@ Device (BATX)
Local2 = SBRS Local2 = SBRS
// See if within ~3% of full // See if within ~3% of full
ShiftRight (Local2, 5, Local3) Local3 = Local2 >> 5
If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3)
{ {
Local1 = Local2 Local1 = Local2

4
src/ec/smsc/mec1308/acpi/battery.asl
View file

@ -59,7 +59,7 @@ Device (BAT0)
// Swap bytes in a word // Swap bytes in a word
Method (SWAB, 1, NotSerialized) Method (SWAB, 1, NotSerialized)
{ {
ShiftRight (Arg0, 8, Local0) Local0 = Arg0 >> 8
ShiftLeft (Arg0, 8, Local1) ShiftLeft (Arg0, 8, Local1)
And (Local1, 0xFF00, Local1) And (Local1, 0xFF00, Local1)
Or (Local0, Local1, Local0) Or (Local0, Local1, Local0)
@ -156,7 +156,7 @@ Device (BAT0)
Local2 = SWAB (BTDF) Local2 = SWAB (BTDF)
// See if within ~3% of full // See if within ~3% of full
ShiftRight (Local2, 5, Local3) Local3 = Local2 >> 5
If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3)
{ {
Local1 = Local2 Local1 = Local2

2
src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl
View file

@ -48,7 +48,7 @@ Device (MBRS)
CreateDWordField (MSBF, \_SB.MBRS._Y1D._MAX, MS01) CreateDWordField (MSBF, \_SB.MBRS._Y1D._MAX, MS01)
CreateDWordField (MSBF, \_SB.MBRS._Y1D._LEN, MEM2) CreateDWordField (MSBF, \_SB.MBRS._Y1D._LEN, MEM2)
And (\_SB.PCI0.TOLM, 0xF800, Local1) And (\_SB.PCI0.TOLM, 0xF800, Local1)
ShiftRight (Local1, 0x04, Local1) Local1 >>= 4
Local1-- Local1--
If (Local1 > 0x10) If (Local1 > 0x10)
{ {

2
src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl
View file

@ -42,7 +42,7 @@ Method (_CRS, 0, NotSerialized)
CreateDWordField (PBRS, \_SB.PCI0._Y08._MAX, MEMH) CreateDWordField (PBRS, \_SB.PCI0._Y08._MAX, MEMH)
CreateDWordField (PBRS, \_SB.PCI0._Y08._LEN, LENM) CreateDWordField (PBRS, \_SB.PCI0._Y08._LEN, LENM)
And (\_SB.PCI0.TOLM, 0xF800, Local1) And (\_SB.PCI0.TOLM, 0xF800, Local1)
ShiftRight (Local1, 0x04, Local1) Local1 >>= 4
ShiftLeft (Local1, 0x14, MEML) ShiftLeft (Local1, 0x14, MEML)
MEMH = IO_APIC_ADDR - 1 MEMH = IO_APIC_ADDR - 1
LENM = IO_APIC_ADDR - MEML LENM = IO_APIC_ADDR - MEML

2
src/mainboard/google/cyan/variants/terra/include/variant/acpi/mainboard.asl
View file

@ -10,7 +10,7 @@ Scope (\_SB)
{ {
Method (GPID, 0, Serialized) // GPID: Get Project ID for Terra2/Terra3 Method (GPID, 0, Serialized) // GPID: Get Project ID for Terra2/Terra3
{ {
And( ShiftRight (\BDID, 3, Local0), 0x01, Local0) And(\BDID >> 3, 0x01, Local0)
Return (Local0) Return (Local0)
} }
} }