From 043976065b006b42a9ec47cf34605eaec4815c6f Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 15 Apr 2016 10:34:31 -0700 Subject: [PATCH] soc/intel/apollolake: Do not re-save BIST result BIST result is already stored by arch/x86/bootblock_ctr0.S in mm0. Also, eax does not contain BIST result by the time control reaches bootblock_pre_c_entry. bootblock_crt0.S saves timestamp in mm2 which was being overwritten here. Thus, remove the saving of BIST result from SoC code. Change-Id: I65444689cf104c59c84574019f5daf82aab10bc7 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/14381 Reviewed-by: Stefan Reinauer Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Andrey Petrov --- src/soc/intel/apollolake/bootblock/cache_as_ram.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/soc/intel/apollolake/bootblock/cache_as_ram.S b/src/soc/intel/apollolake/bootblock/cache_as_ram.S index 3c7bd299c2..9d2bba01e8 100644 --- a/src/soc/intel/apollolake/bootblock/cache_as_ram.S +++ b/src/soc/intel/apollolake/bootblock/cache_as_ram.S @@ -25,10 +25,6 @@ .global bootblock_pre_c_entry bootblock_pre_c_entry: - /* - * eax: BIST value - */ - movd %eax, %mm2 .global cache_as_ram cache_as_ram: