GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Google/Snow: Revise bootblock initialization. 

It's fine to always start timer even in suspend/resume mode, so we can
move the timer_start() back to the very beginning of boot procedure.
That provides more precise boot time information.

With that timer change, the wake up state test procedure can be simplified.

Verified by building and booting firmware image on Google/Snow successfully,
and then suspend-resume without problem (suspend_stress_test).

Change-Id: I0d739650dbff4eb3a75acbbf1e4356f2569b487d
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/3151
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Hung-Te Lin 2013-04-30 16:14:35 +08:00 committed by Ronald G. Minnich
parent c99ae5d9a9
commit 043b823a73
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mainboard/google/snow/bootblock.c
View File

@ -30,17 +30,14 @@
void bootblock_mainboard_init(void); void bootblock_mainboard_init(void);
void bootblock_mainboard_init(void) void bootblock_mainboard_init(void)
{ {
switch (snow_get_wakeup_state()) {
case SNOW_WAKEUP_DIRECT:
snow_wakeup();
break;
case SNOW_IS_NOT_WAKEUP:
/* kick off the microsecond timer. /* kick off the microsecond timer.
* We want to do this as early as we can. * We want to do this as early as we can.
*/ */
timer_start(); timer_start();
break;
if (snow_get_wakeup_state() == SNOW_WAKEUP_DIRECT) {
snow_wakeup();
/* Never returns. */
} }
/* For most ARM systems, we have to initialize firmware media source /* For most ARM systems, we have to initialize firmware media source