From 044fc9f6716c6978ea29ffa53be1a9facbe00d6c Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 14 Apr 2023 02:34:37 +0530 Subject: [PATCH] soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static The patch makes `cse_get_fpt_partition_info()` AP local/static as all the references to this function are in local to the cse_lite.c file. BUG=b:273661726 TEST=Able to build and boot google/marasov with this code change. Signed-off-by: Subrata Banik Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac Reviewed-on: https://review.coreboot.org/c/coreboot/+/74388 Reviewed-by: Kangheui Won Reviewed-by: Arthur Heymans Reviewed-by: Sridhar Siricilla Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/soc/intel/common/block/cse/cse_lite.c | 3 ++- src/soc/intel/common/block/include/intelblocks/cse.h | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 4cc4f51d86..d6c83479de 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -1220,7 +1220,8 @@ static enum cb_err send_get_fpt_partition_info_cmd(enum fpt_partition_id id, return CB_SUCCESS; } -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp) +static enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, + struct fw_version_resp *resp) { if (vboot_recovery_mode_enabled()) { printk(BIOS_WARNING, diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index f3a7f83666..c893846e19 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -561,10 +561,4 @@ void cse_enable_ptt(bool state); */ enum cb_err cse_get_fw_feature_state(uint32_t *feature_state); -/* - * The function sends a HECI command to get the partition information of the shared ID. - * The retrieved partition is stored in the memory pointed to by the resp pointer. - * The function returns 0 on success and < 0 on failure. - */ -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp); #endif // SOC_INTEL_COMMON_CSE_H