From 049e77e6bcbe4918e7eeb685627cd0b5914bad5a Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Thu, 23 Mar 2023 16:27:45 -0400 Subject: [PATCH] nb/intel/i440bx: Roll sdram_set_spd_registers() into parent Being a static function, compiler is already putting its contents in sdram_initialize(), its only caller. Change-Id: Ie74d2283ef672a267d6a0c66d94aa0610f36c4f1 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/74033 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/northbridge/intel/i440bx/raminit.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c index 8d9ceff71a..3c0951df08 100644 --- a/src/northbridge/intel/i440bx/raminit.c +++ b/src/northbridge/intel/i440bx/raminit.c @@ -946,15 +946,6 @@ static void set_dram_row_attributes(void) PRINT_DEBUG("%s has been set to 0x%02x\n", "DRAMC", value); } -static void sdram_set_spd_registers(void) -{ - /* Setup DRAM row boundary registers and other attributes. */ - set_dram_row_attributes(); - - /* Setup DRAM buffer strength. */ - set_dram_buffer_strength(); -} - static void sdram_enable(void) { int i; @@ -1009,7 +1000,10 @@ void sdram_initialize(int s3resume) dump_spd_registers(); sdram_set_registers(); - sdram_set_spd_registers(); + /* Set up DRAM row boundary registers and other attributes. */ + set_dram_row_attributes(); + /* Set up DRAM buffer strength. */ + set_dram_buffer_strength(); sdram_enable(); /* Clear any errors reported during raminit. */