GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/prodrive/hermes: Disable ACPI S3 and S4 with SPS 

Hermes can be used with either CSME or SPS firmware. However, the SPS
(Server Platform Services) firmware does not support ACPI S3 and S4
sleep states, and coreboot should not report S3 and S4 as supported.

Add a Kconfig option to be selected when building coreboot to use with
SPS firmware, which allows disabling ACPI S3 and S4 sleep state support.

Change-Id: I9d0fa8530e198e86415f92da6719d2fb0d2401ec
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54058
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
Angel Pons 2021-05-11 12:34:04 +02:00 committed by Patrick Georgi
parent a1e7ab6f82
commit 04ae6aa8ad
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mainboard/prodrive/hermes/Kconfig
View File

@ -14,10 +14,18 @@ config BOARD_PRODRIVE_HERMES_BASEBOARD
select INTEL_GMA_HAVE_VBT
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select ONBOARD_VGA_IS_PRIMARY
select HAVE_ACPI_RESUME
select HAVE_ACPI_RESUME if !HERMES_USES_SPS_FIRMWARE
select DISABLE_ACPI_HIBERNATE if HERMES_USES_SPS_FIRMWARE
if BOARD_PRODRIVE_HERMES_BASEBOARD
config HERMES_USES_SPS_FIRMWARE
bool "Build for use with SPS (Server Platform Services) firmware"
help
Depending on the intended use case, the Hermes mainboard can use either
CSME or SPS firmware SKUs. Choose this option if using SPS firmware, as
SPS doesn't support ACPI S3 and S4 sleep states.
config MAINBOARD_FAMILY
string
default "PRODRIVE_HERMES_SERIES"