GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/beltino/**/hda_verb.c: Correct pin configs 

NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead
applied onto NID 0x1a. Fix that, so that it matches original Chromium
sources for the boards.

Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37852
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Angel Pons 2019-12-19 19:58:16 +01:00 committed by Patrick Georgi
parent 416f411b8c
commit 0558d0c215
5 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/beltino/variants/mccloud/hda_verb.c
View File

@ -45,16 +45,16 @@ const u32 cim_verb_data[] = {
// black, jack detect
// mic in, analog
// connector, left panel
AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable

6
src/mainboard/google/beltino/variants/monroe/hda_verb.c
View File

@ -41,16 +41,16 @@ const u32 cim_verb_data[] = {
AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
/* Pin Complex (NID 0x18) MIC1 PORTB - Disabled*/
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
/* Pin Complex (NID 0x19) MIC2 PORTF - 3.5mm Jack*/
AZALIA_PIN_CFG(0, 0x18, 0x03a11020),
AZALIA_PIN_CFG(0, 0x19, 0x03a11020),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable

6
src/mainboard/google/beltino/variants/panther/hda_verb.c
View File

@ -45,16 +45,16 @@ const u32 cim_verb_data[] = {
// black, jack detect
// mic in, analog
// connector, left panel
AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable

6
src/mainboard/google/beltino/variants/tricky/hda_verb.c
View File

@ -45,16 +45,16 @@ const u32 cim_verb_data[] = {
// black, jack detect
// mic in, analog
// connector, left panel
AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable

6
src/mainboard/google/beltino/variants/zako/hda_verb.c
View File

@ -45,16 +45,16 @@ const u32 cim_verb_data[] = {
// black, jack detect
// mic in, analog
// connector, left panel
AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */
AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable