GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/agesa: Remove unused assignments 

'Status' is assigned a value three times before it is checked.
Remove the first two assignments.

Change-Id: Id7136d62b4dbd6dce877983467960373b3a7ac22
Signed-off-by: Joe Moore <awokd@danwin1210.me>
Found-by: Coverity CID 1241809
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36257
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Joe Moore 2019-10-23 05:16:56 -06:00 committed by Nico Huber
parent efa022db50
commit 0560a66450
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
View File

@ -474,13 +474,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}

2
src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
View File

@ -488,13 +488,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}

2
src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
View File

@ -488,13 +488,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}