From 060c7c7f0618dd281fb38942916b5f9737d2b9ca Mon Sep 17 00:00:00 2001 From: Ruihai Zhou Date: Fri, 22 Sep 2023 10:21:37 +0800 Subject: [PATCH] mb/google/corsola: Fine tune LCM ADC voltages The tolerance of LCM voltage table is too small which leads to wrong panel ID detection. Fine tune LCM ADC voltages based on hardware calculations. BUG=b:300418909 TEST=FW screen display normally Signed-off-by: Ruihai Zhou Change-Id: Id8dec043584f4c552837f70adb491584bfda7acf Reviewed-on: https://review.coreboot.org/c/coreboot/+/78063 Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu Reviewed-by: Yidi Lin --- src/mainboard/google/corsola/boardid.c | 24 ++++++++++---------- src/mainboard/google/corsola/panel_starmie.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mainboard/google/corsola/boardid.c b/src/mainboard/google/corsola/boardid.c index a0c08abb54..59c9f5cf03 100644 --- a/src/mainboard/google/corsola/boardid.c +++ b/src/mainboard/google/corsola/boardid.c @@ -23,18 +23,18 @@ enum { static const unsigned int lcm_voltages[ADC_LEVELS] = { /* ID : Voltage (unit: uV) */ - [0] = 0, - [1] = 283000, - [2] = 394000, - [3] = 490000, - [4] = 640000, - [5] = 712000, - [6] = 800000, - [7] = 867000, - [8] = 960000, - [9] = 1070000, - [10] = 1190000, - [11] = 1434000, + [0] = 0, + [1] = 89191, + [2] = 148419, + [3] = 205240, + [4] = 282774, + [5] = 393556, + [6] = 495561, + [7] = 641944, + [8] = 798049, + [9] = 960054, + [10] = 1191264, + [11] = 1433691, }; static const unsigned int ram_voltages[ADC_LEVELS] = { diff --git a/src/mainboard/google/corsola/panel_starmie.c b/src/mainboard/google/corsola/panel_starmie.c index 106f722080..c55d82d4c7 100644 --- a/src/mainboard/google/corsola/panel_starmie.c +++ b/src/mainboard/google/corsola/panel_starmie.c @@ -49,13 +49,13 @@ static void mipi_panel_power_on(void) static struct panel_description starmie_panels[] = { /* K&D panel vendor and ILI9882T chip, K&D and STA panel are identical except manufacturer_name. */ - [3] = { + [6] = { .power_on = mipi_panel_power_on, .name = "STA_ILI9882T", .orientation = LB_FB_ORIENTATION_LEFT_UP, }, /* STA panel vendor and ILI9882T chip */ - [8] = { + [9] = { .power_on = mipi_panel_power_on, .name = "STA_ILI9882T", .orientation = LB_FB_ORIENTATION_LEFT_UP,