GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inteltool: Fix clean-up and close related TODO 

We have to call pci_free_dev() for each device we allocated with
pci_get_dev(). Since that's not the case for `sb`, we can close
this TODO.

Change-Id: I1ef80c837263a205467f835156dcb8fa667d3a8f
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/19587
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Nico Huber 2017-04-05 17:33:46 +02:00 committed by Stefan Reinauer
parent ed9c9ce268
commit 0660c6c1ff
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/inteltool/inteltool.c
View File

@ -568,8 +568,12 @@ int main(int argc, char *argv[])
}
/* Clean up */
if (ahci)
pci_free_dev(ahci);
if (gfx)
pci_free_dev(gfx);
pci_free_dev(nb);
// pci_free_dev(sb); // TODO: glibc detected "double free or corruption"
/* `sb` wasn't allocated by pci_get_dev() */
pci_cleanup(pacc);
return 0;