From 068c2595f2a3cc57d73849926f420bd6f63d72f6 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sat, 14 Nov 2020 01:31:15 +0100 Subject: [PATCH] nb/intel/sandybridge: Run `read_mpr_training` before write training Reference code does this, so follow suit. Tested on Asus P8H61-M PRO, still boots. Change-Id: I21c5161da55b380dd4b2d574b22a1ef038f55fce Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/47611 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/northbridge/intel/sandybridge/raminit_native.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c index e0b5a3dfc2..ae9a4f46fa 100644 --- a/src/northbridge/intel/sandybridge/raminit_native.c +++ b/src/northbridge/intel/sandybridge/raminit_native.c @@ -684,16 +684,16 @@ int try_init_dram_ddr3(ramctr_timing *ctrl, int fast_boot, int s3resume, int me_ if (err) return err; + err = read_mpr_training(ctrl); + if (err) + return err; + err = write_training(ctrl); if (err) return err; printram("CP5a\n"); - err = read_mpr_training(ctrl); - if (err) - return err; - printram("CP5b\n"); err = command_training(ctrl);