GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/nissa/var/joxer: Remove fw_config probe for storage devices 

When fw_config is unprovisioned, devicetree will disable all probed
devices. However, boot-critical devices such as storage devices need to
be enabled.

As a temporary workaround while adding devicetree support for this,
remove the fw_config probe for storage devices so that all storage
devices are always enabled. On eMMC SKUs, UFS and ISH will be disabled
by the PCI scan anyway. On UFS SKUs, eMMC is not disabled by the PCI
scan, but keeping it enabled should have no functional impact, only a
possible power impact.

BUG=b:285477026
TEST=On joxer eMMC and UFS SKUs, boot to OS and
`suspend_stress_test -c 10`

Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Change-Id: I834bd81ce636a6f32d50434cbf07b1d572620492
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75757
Reviewed-by: Derek Huang <derekhuang@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Mark Hsieh 2023-06-12 16:26:54 +08:00 committed by Eric Lai
parent 6c0961ae43
commit 07046ca217
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/google/brya/variants/joxer/overridetree.cb
View File

@ -196,15 +196,9 @@ chip soc/intel/alderlake
end
end
device ref pcie_rp7 off end # PCIE7 no SD card
device ref emmc on
probe STORAGE STORAGE_EMMC
end
device ref ish on
probe STORAGE STORAGE_UFS
end
device ref ufs on
probe STORAGE STORAGE_UFS
end
device ref emmc on end
device ref ish on end
device ref ufs on end
device ref pch_espi on
chip ec/google/chromeec
use conn0 as mux_conn[0]