GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism/librem_cnl: Use FMAP-based SPD cache 

Use a FMAP region to cache SPD data, providing improvements in boot
time and detection of change in DIMM population (which FSP will
sometimes fail to detect / fail to invalidate the MRC cache).

Adapted from implementation used in google/hatch.

Test: build/boot Librem Mini v2, verify SPD cache used, changes
in DIMM population properly detected.

Change-Id: I15cb9aa8b00d39d098a0f901aee026bac1161a80
Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48549
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2020-12-02 15:35:34 -06:00 committed by Hung-Te Lin
parent c1ce6f80c4
commit 087c4f2894
2 changed files with 95 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/purism/librem_cnl/Kconfig
View File

@ -8,6 +8,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_CNL
select INTEL_GMA_HAVE_VBT
select NO_UART_ON_SUPERIO
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select SPD_CACHE_IN_FMAP
select SPD_READ_BY_WORD
select USE_LEGACY_8254_TIMER

81
src/mainboard/purism/librem_cnl/romstage.c
View File

@ -1,22 +1,17 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h>
#include <soc/cnl_memcfg_init.h>
#include <soc/romstage.h>
#include <spd_bin.h>
#include <spd_cache.h>
#include "variant.h"
static const struct cnl_mb_cfg memcfg = {
void mainboard_memory_init_params(FSPM_UPD *memupd)
{
FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig;
/* Parameters required to access SPD for CH0D0/CH0D1/CH1D0/CH1D1. */
.spd[0] = {
.read_type = READ_SMBUS,
.spd_spec = {.spd_smbus_address = 0xa0},
},
.spd[1] = {.read_type = NOT_EXISTING},
.spd[2] = {
.read_type = READ_SMBUS,
.spd_spec = {.spd_smbus_address = 0xa4},
},
.spd[3] = {.read_type = NOT_EXISTING},
struct cnl_mb_cfg memcfg = {
/*
* Rcomp resistor values. These values represent the resistance in
@ -47,9 +42,65 @@ static const struct cnl_mb_cfg memcfg = {
.ect = 0,
};
void mainboard_memory_init_params(FSPM_UPD *memupd)
{
FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig;
/* Read spd block to get memory config */
struct spd_block blk = {
.addr_map = { 0x50, 0x52, },
};
uint8_t *spd_cache;
size_t spd_cache_sz;
bool need_update_cache = false;
bool dimm_changed = true;
/* load spd cache from RW_SPD_CACHE */
if (load_spd_cache(&spd_cache, &spd_cache_sz) == CB_SUCCESS) {
if (!spd_cache_is_valid(spd_cache, spd_cache_sz)) {
printk(BIOS_WARNING, "Invalid SPD cache\n");
} else {
dimm_changed = check_if_dimm_changed(spd_cache, &blk);
if (dimm_changed && memupd->FspmArchUpd.NvsBufferPtr != NULL) {
/* Set mrc_cache as invalid */
printk(BIOS_INFO, "Set mrc_cache as invalid\n");
memupd->FspmArchUpd.NvsBufferPtr = NULL;
}
}
need_update_cache = true;
}
if (!dimm_changed) {
spd_fill_from_cache(spd_cache, &blk);
} else {
/* Access memory info through SMBUS. */
get_spd_smbus(&blk);
if (need_update_cache && update_spd_cache(&blk) == CB_ERR)
printk(BIOS_WARNING, "update SPD cache failed\n");
}
if (blk.spd_array[0] == NULL) {
memcfg.spd[0].read_type = NOT_EXISTING;
} else {
memcfg.spd[0].read_type = READ_SPD_MEMPTR;
memcfg.spd[0].spd_spec.spd_data_ptr_info.spd_data_len = blk.len;
memcfg.spd[0].spd_spec.spd_data_ptr_info.spd_data_ptr =
(uintptr_t)blk.spd_array[0];
}
memcfg.spd[1].read_type = NOT_EXISTING;
if (blk.spd_array[1] == NULL) {
memcfg.spd[2].read_type = NOT_EXISTING;
} else {
memcfg.spd[2].read_type = READ_SPD_MEMPTR;
memcfg.spd[2].spd_spec.spd_data_ptr_info.spd_data_len = blk.len;
memcfg.spd[2].spd_spec.spd_data_ptr_info.spd_data_ptr =
(uintptr_t)blk.spd_array[1];
}
memcfg.spd[3].read_type = NOT_EXISTING;
dump_spd_info(&blk);
cannonlake_memcfg_init(mem_cfg, &memcfg);
variant_memory_init_params(mem_cfg);
}