GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commonlib/mem_chip_info: Add clarifying documentation comments 

This patch just adds some comments to the recently merged mem_chip_info
struct for communicating memory type information to the payload/OS, to
clarify the expected format in which values are to be written into the
fields.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I2c28b3bdcdb13b7f270fb87a8f06e2cf448cddec
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63944
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shelley Chen <shchen@google.com>
This commit is contained in:
Julius Werner 2022-04-28 18:23:14 -07:00
parent dfb8d80c1a
commit 08c2217192
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h
View File

@ -18,12 +18,12 @@ struct mem_chip_info {
uint8_t num_channels; uint8_t num_channels;
uint8_t reserved[6]; uint8_t reserved[6];
struct mem_chip_channel { struct mem_chip_channel {
uint64_t density; uint64_t density; /* number in _bytes_, not Megabytes! */
uint8_t io_width; uint8_t io_width; /* should be `8`, `16`, `32` or `64` */
uint8_t manufacturer_id; uint8_t manufacturer_id; /* raw value from MR5 */
uint8_t revision_id[2]; uint8_t revision_id[2]; /* raw values from MR6 and MR7 */
uint8_t reserved[4]; uint8_t reserved[4];
uint8_t serial_id[8]; /* LPDDR5 only */ uint8_t serial_id[8]; /* LPDDR5 only, MR47 - MR54 */
} channel[0]; } channel[0];
}; };