From 0972871a238e86f74119958c392fefe8c6d995fc Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Wed, 31 Mar 2021 18:30:29 -0700 Subject: [PATCH] coreboot_tables: Print strapping IDs when adding them to coreboot table These used to be printed before CB:46605. Having them in the logs can be a huge timesaver when debugging logs sent to you by other people (especially from systems that don't boot all the way). Let's add them back. Signed-off-by: Julius Werner Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d Reviewed-on: https://review.coreboot.org/c/coreboot/+/52011 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- src/lib/coreboot_table.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 29be857e1e..cb85a1819a 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -305,10 +306,20 @@ static struct lb_board_config *lb_board_config(struct lb_header *header) config->tag = LB_TAG_BOARD_CONFIG; config->size = sizeof(*config); + const uint64_t fw_config = fw_config_get(); config->board_id = board_id(); config->ram_code = ram_code(); config->sku_id = sku_id(); - config->fw_config = pack_lb64(fw_config_get()); + config->fw_config = pack_lb64(fw_config); + + if (config->board_id != UNDEFINED_STRAPPING_ID) + printk(BIOS_INFO, "Board ID: %d\n", config->board_id); + if (config->ram_code != UNDEFINED_STRAPPING_ID) + printk(BIOS_INFO, "RAM code: %d\n", config->ram_code); + if (config->sku_id != UNDEFINED_STRAPPING_ID) + printk(BIOS_INFO, "SKU ID: %d\n", config->sku_id); + if (fw_config != UNDEFINED_FW_CONFIG) + printk(BIOS_INFO, "FW config: %#" PRIx64 "\n", fw_config); return config; }