GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4 

Since nami proto did not have any external pull on MEM_CONFIG_4, use a
weak internal pull down before reading it.

BUG=b:74420123
TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami.

Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/25103
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh 2018-03-12 06:29:52 -07:00 committed by Aaron Durbin
parent 898e2b4399
commit 0995b2da38
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/poppy/variants/nami/memory.c
View File

@ -82,7 +82,7 @@ static void fill_ddr4_memory_params(struct memory_params *p)
void variant_memory_params(struct memory_params *p) void variant_memory_params(struct memory_params *p)
{ {
memset(p, 0, sizeof(*p)); memset(p, 0, sizeof(*p));
gpio_input(GPIO_MEM_CONFIG_4); gpio_input_pulldown(GPIO_MEM_CONFIG_4);
if (gpio_get(GPIO_MEM_CONFIG_4)) if (gpio_get(GPIO_MEM_CONFIG_4))
/* set to LPDDR3 */ /* set to LPDDR3 */
fill_lpddr3_memory_params(p); fill_lpddr3_memory_params(p);