GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mb/google/skyrim/var/winterhold: Change to read the eMMC clkreq instead

Browse source 
Because WD SSD drive isn't holding the clock low for some reason.
So we change to read eMMC clkreq signal instead.

BRANCH=none
BUG=b:274377518
TEST=emerge-skyrim coreboot chromeos-bootimage and verify ok.

Change-Id: I1329386631dc54209db54ac146e4aafe95b6a3ac
Signed-off-by: Rex Chou <rex_chou@compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
This commit is contained in:
EricKY Cheng 2023-04-20 17:21:24 +08:00 committed by Martin Roth
parent 2ee716227e
commit 09eab1f1a4
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
View file

@ -74,7 +74,7 @@ static const fsp_dxio_descriptor nvme_dxio_descriptors[] = {
}, },
}; };
#define NVME_CLKREQ_GPIO 92 #define EMMC_CLKREQ_GPIO 115
void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num) void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num)
{ {
/* /*
@ -85,13 +85,13 @@ void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t
* This allows checking the state of the NVMe device clkreq signal and enabling * This allows checking the state of the NVMe device clkreq signal and enabling
* either eMMC or NVMe based on that. * either eMMC or NVMe based on that.
*/ */
if (gpio_get(NVME_CLKREQ_GPIO)) { if (gpio_get(EMMC_CLKREQ_GPIO)) {
printk(BIOS_DEBUG, "Enabling eMMC.\n");
*dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
*dxio_descs = emmc_dxio_descriptors;
} else {
printk(BIOS_DEBUG, "Enabling NVMe.\n"); printk(BIOS_DEBUG, "Enabling NVMe.\n");
*dxio_num = ARRAY_SIZE(nvme_dxio_descriptors); *dxio_num = ARRAY_SIZE(nvme_dxio_descriptors);
*dxio_descs = nvme_dxio_descriptors; *dxio_descs = nvme_dxio_descriptors;
} else {
printk(BIOS_DEBUG, "Enabling eMMC.\n");
*dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
*dxio_descs = emmc_dxio_descriptors;
} }
} }