GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/cannonlake: Remove unnecessary function 

parse_devicetree() just calls parse_devicetree_param(). To be aligned
with other platforms, remove it and rename parse_devicetree_param() to
parse_devicetree().

Change-Id: I1128ab709cfdb02bbdb505c3f22f5433a30cb3c1
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52488
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer 2021-04-19 00:33:31 +02:00 committed by Michael Niewöhner
parent 78976c153a
commit 0a6cf23ce7
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/soc/intel/cannonlake/fsp_params.c
View File

@ -59,7 +59,7 @@ static uint8_t get_param_value(const config_t *config, uint32_t dev_offset)
} }
#if CONFIG(SOC_INTEL_COMETLAKE) #if CONFIG(SOC_INTEL_COMETLAKE)
static void parse_devicetree_param(const config_t *config, FSP_S_CONFIG *params) static void parse_devicetree(const config_t *config, FSP_S_CONFIG *params)
{ {
uint32_t dev_offset = 0; uint32_t dev_offset = 0;
uint32_t i = 0; uint32_t i = 0;
@ -81,20 +81,13 @@ static void parse_devicetree_param(const config_t *config, FSP_S_CONFIG *params)
} }
} }
#else #else
static void parse_devicetree_param(const config_t *config, FSP_S_CONFIG *params) static void parse_devicetree(const config_t *config, FSP_S_CONFIG *params)
{ {
for (int i = 0; i < ARRAY_SIZE(serial_io_dev); i++) for (int i = 0; i < ARRAY_SIZE(serial_io_dev); i++)
params->SerialIoDevMode[i] = get_param_value(config, i); params->SerialIoDevMode[i] = get_param_value(config, i);
} }
#endif #endif
static void parse_devicetree(FSP_S_CONFIG *params)
{
const config_t *config = config_of_soc();
parse_devicetree_param(config, params);
}
/* Ignore LTR value for GBE devices */ /* Ignore LTR value for GBE devices */
static void ignore_gbe_ltr(void) static void ignore_gbe_ltr(void)
{ {
@ -139,7 +132,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
config_t *config = config_of_soc(); config_t *config = config_of_soc();
/* Parse device tree and enable/disable devices */ /* Parse device tree and enable/disable devices */
parse_devicetree(params); parse_devicetree(config, params);
/* Load VBT before devicetree-specific config. */ /* Load VBT before devicetree-specific config. */
params->GraphicsConfigPtr = (uintptr_t)vbt_get(); params->GraphicsConfigPtr = (uintptr_t)vbt_get();