GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86/acpi_bert_storage: change return type of bert_errors_present 

The return value is a boolean, so use the bool type. Also add the
types.h header to have the bool type defined. Also change type of
bert_region_broken static variable to bool.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I13d6472deeb26ba92d257761df069e32d9b2e5d4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55023
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Felix Held 2021-05-27 20:16:45 +02:00 committed by Patrick Georgi
parent f156f73c62
commit 0a88c6057a
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/arch/x86/acpi_bert_storage.c
View File

@ -8,6 +8,7 @@
#include <acpi/acpi.h>
#include <arch/bert_storage.h>
#include <string.h>
#include <types.h>
/* BERT region management: Allow the chipset to determine the specific
* location of the BERT region. We find that base and size, then manage
@ -19,7 +20,7 @@
* resume cycles. If the requirements change, consider using IMD to help
* manage the space.
*/
static int bert_region_broken;
static bool bert_region_broken;
static void *bert_region_base;
static size_t bert_region_size;
static size_t bert_region_used;
@ -32,9 +33,9 @@ size_t bert_storage_remaining(void)
return bert_region_broken ? 0 : bert_region_size - bert_region_used;
}
int bert_errors_present(void)
bool bert_errors_present(void)
{
return bert_region_broken ? 0 : !!bert_region_used;
return !bert_region_broken && bert_region_used;
}
void bert_errors_region(void **start, size_t *size)
@ -585,14 +586,14 @@ static void bert_storage_setup(int unused)
/* Always start with a blank bert region. Make sure nothing is
* maintained across reboots or resumes.
*/
bert_region_broken = 0;
bert_region_broken = false;
bert_region_used = 0;
bert_reserved_region(&bert_region_base, &bert_region_size);
if (!bert_region_base || !bert_region_size) {
printk(BIOS_ERR, "Bug: Can't find/add BERT storage area\n");
bert_region_broken = 1;
bert_region_broken = true;
return;
}

4
src/arch/x86/include/arch/bert_storage.h
View File

@ -3,8 +3,8 @@
#ifndef _BERT_STORAGE_H_
#define _BERT_STORAGE_H_
#include <stdint.h>
#include <acpi/acpi.h>
#include <types.h>
/* Items in the BERT region
*
@ -55,7 +55,7 @@ void bert_errors_region(void **start, size_t *size);
/* Get amount of available storage left for error info */
size_t bert_storage_remaining(void);
/* Find if errors were added, a BERT region is present, and ACPI table needed */
int bert_errors_present(void);
bool bert_errors_present(void);
/* Get the number of entries associated with status */
static inline size_t bert_entry_count(acpi_generic_error_status_t *status)