GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/common/rcba_pirq: Use correct size_t length modifier 

Building an image for the Lenovo T60 with `x86_64-linux-gnu-gcc-11`
fails with the format warning below.

        CC         ramstage/southbridge/intel/common/rcba_pirq.o
    src/southbridge/intel/common/rcba_pirq.c: In function 'intel_acpi_gen_def_acpi_pirq':
    src/southbridge/intel/common/rcba_pirq.c:86:69: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
       86 |                 printk(BIOS_SPEW, "ACPI_PIRQ_GEN: %s: pin=%d pirq=%ld\n",
          |                                                                   ~~^
          |                                                                     |
          |                                                                     long int
          |                                                                   %d
       87 |                        dev_path(dev), int_pin - PCI_INT_A,
       88 |                        pirq_idx(pin_irq_map[map_count].pic_pirq));
          |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |                        |
          |                        size_t {aka unsigned int}

The return value of `pirq_idx()` is of type `size_t`, so use the
appropriate length modifier `z`.

Change-Id: I7af24cee536b81e4825b77942bcac75afeb9f476
Found-by: gcc (Debian 11.2.0-13) 11.2.0
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60194
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Paul Menzel 2021-12-17 14:16:23 +01:00 committed by Felix Held
parent d448f8ce0f
commit 0afecdf95a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/intel/common/rcba_pirq.c
View File

@ -83,7 +83,7 @@ void intel_acpi_gen_def_acpi_pirq(const struct device *lpc)
pin_irq_map[map_count].pic_pirq = pirq; pin_irq_map[map_count].pic_pirq = pirq;
/* PIRQs are mapped to GSIs starting at 16 */ /* PIRQs are mapped to GSIs starting at 16 */
pin_irq_map[map_count].apic_gsi = 16 + pirq_idx(pirq); pin_irq_map[map_count].apic_gsi = 16 + pirq_idx(pirq);
printk(BIOS_SPEW, "ACPI_PIRQ_GEN: %s: pin=%d pirq=%ld\n", printk(BIOS_SPEW, "ACPI_PIRQ_GEN: %s: pin=%d pirq=%zd\n",
dev_path(dev), int_pin - PCI_INT_A, dev_path(dev), int_pin - PCI_INT_A,
pirq_idx(pin_irq_map[map_count].pic_pirq)); pirq_idx(pin_irq_map[map_count].pic_pirq));
map_count++; map_count++;