From 0b42c8ae0c0858318a59263285d08d274801ddee Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Tue, 26 Sep 2017 13:37:49 +0200 Subject: [PATCH] siemens/nc_fpga: Move some parameters to another function For general use of this driver it is necessary to move some parameters from init_fan_ctrl() to init_temp_mon(). This shift does not lead to any functional change. Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17 Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/21694 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Paul Menzel --- src/drivers/siemens/nc_fpga/nc_fpga.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c index 61d9e0841e..28fc6e2edf 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga.c +++ b/src/drivers/siemens/nc_fpga/nc_fpga.c @@ -53,6 +53,11 @@ static void init_temp_mon (void *base_adr) } } ctrl->sensornum = num; + + /* Program sensor selection and temperature thresholds. */ + FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect); + FPGA_SET_PARAM(T_Warn, ctrl->t_warn); + FPGA_SET_PARAM(T_Crit, ctrl->t_crit); } static void init_fan_ctrl (void *base_adr) @@ -61,9 +66,6 @@ static void init_fan_ctrl (void *base_adr) volatile fan_ctrl_t *ctrl = (fan_ctrl_t *)base_adr; /* Program all needed fields of FAN controller. */ - FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect); - FPGA_SET_PARAM(T_Warn, ctrl->t_warn); - FPGA_SET_PARAM(T_Crit, ctrl->t_crit); FPGA_SET_PARAM(FANSamplingTime, ctrl->samplingtime); FPGA_SET_PARAM(FANSetPoint, ctrl->setpoint); FPGA_SET_PARAM(FANHystCtrl, ctrl->hystctrl);