GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

emulation/{i440fx,q35}: Don't use PCI driver to set root PCI dev ops 

This devices is always present so hooking up the ops in devicetree makes
more sense.

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: I369129e365ce8596cad25b97d12168bb08e3ed0e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76241
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Arthur Heymans 2023-07-04 12:15:56 +02:00 committed by Felix Held
parent edf1ffef9f
commit 0b5802449d
4 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/emulation/qemu-i440fx/devicetree.cb
View File

@ -1,7 +1,7 @@
chip mainboard/emulation/qemu-i440fx chip mainboard/emulation/qemu-i440fx
device cpu_cluster 0 on end device cpu_cluster 0 on end
device domain 0 on device domain 0 on
device pci 0.0 on end # northbridge (i440fx) device pci 0.0 on ops nb_operations end # northbridge (i440fx)
chip southbridge/intel/i82371eb # southbridge chip southbridge/intel/i82371eb # southbridge
device pci 01.0 on end # ISA bridge device pci 01.0 on end # ISA bridge
device pci 01.1 on end # IDE device pci 01.1 on end # IDE

8
src/mainboard/emulation/qemu-i440fx/mainboard.c
View File

@ -41,15 +41,9 @@ static void qemu_nb_read_resources(struct device *dev)
} }
} }
static struct device_operations nb_operations = { struct device_operations nb_operations = {
.read_resources = qemu_nb_read_resources, .read_resources = qemu_nb_read_resources,
.set_resources = pci_dev_set_resources, .set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
.init = qemu_nb_init, .init = qemu_nb_init,
}; };
static const struct pci_driver nb_driver __pci_driver = {
.ops = &nb_operations,
.vendor = 0x8086,
.device = 0x1237,
};

2
src/mainboard/emulation/qemu-q35/devicetree.cb
View File

@ -1,7 +1,7 @@
chip mainboard/emulation/qemu-q35 chip mainboard/emulation/qemu-q35
device cpu_cluster 0 on end device cpu_cluster 0 on end
device domain 0 on device domain 0 on
device pci 0.0 mandatory end # northbridge (q35) device pci 0.0 mandatory ops nb_operations end # northbridge (q35)
chip southbridge/intel/i82801ix chip southbridge/intel/i82801ix
# present unconditionally # present unconditionally
device pci 1f.0 mandatory device pci 1f.0 mandatory

8
src/mainboard/emulation/qemu-q35/mainboard.c
View File

@ -63,15 +63,9 @@ static void qemu_nb_read_resources(struct device *dev)
} }
static struct device_operations nb_operations = { struct device_operations nb_operations = {
.read_resources = qemu_nb_read_resources, .read_resources = qemu_nb_read_resources,
.set_resources = pci_dev_set_resources, .set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
.init = qemu_nb_init, .init = qemu_nb_init,
}; };
static const struct pci_driver nb_driver __pci_driver = {
.ops = &nb_operations,
.vendor = 0x8086,
.device = 0x29c0,
};