GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

google/beltino: fix LED, simplify function for Tricky variant

Browse source 
Simplify set_power_led() by consolidating switch and setting values
as needed inline based on LED state.

Fix non-off LED polarity for Tricky using correct value from Chromium source

TEST: power on Tricky, observe LED lit / solid

Change-Id: I8bc7c4ae3f83d3f37b76fd5c90a4faed7057ebee
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/17719
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Matt DeVillier 2016-12-02 23:27:32 -06:00 committed by Nico Huber
parent 4015608ed7
commit 0b7c72c70c
1 changed files with 9 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/mainboard/google/beltino/variants/tricky/led.c
View file

@ -19,29 +19,13 @@
void set_power_led(int state) void set_power_led(int state)
{ {
switch (state) { it8772f_gpio_led(IT8772F_GPIO_DEV,
case LED_ON: 2, /* set */
case LED_OFF: 0xF7, /* select */
it8772f_gpio_led(IT8772F_GPIO_DEV, state == LED_OFF ? 0x00 : 0x04, /* polarity */
2 /* set */, state == LED_BLINK ? 0x04 : 0x00, /* pullup/pulldown */
0xF7 /* select */, 0x04, /* output */
state /* polarity: state dependent */, state == LED_BLINK ? 0x00 : 0x04, /* I/O function */
0x00 /* 0=pulldown */, SIO_GPIO_BLINK_GPIO22,
0x04 /* output */, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
0x04 /* 1=Simple IO function */,
SIO_GPIO_BLINK_GPIO22,
IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
break;
case LED_BLINK:
it8772f_gpio_led(IT8772F_GPIO_DEV,
2 /* set */,
0xF7 /* select */,
0x04 /* polarity */,
0x04 /* 1=pullup */,
0x04 /* output */,
0x00, /* 0=Alternate function */
SIO_GPIO_BLINK_GPIO22,
IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
break;
}
} }