GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: Fix clang fallthrough warning 

Clang does not recognize comments to indicate falltrough is intended
behavior.

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: Idcf7a24fc763b80863902702172b4ea950e132b8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77431
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Arthur Heymans 2023-08-25 13:05:19 +02:00 committed by Elyes Haouas
parent d717394384
commit 0ba81d7db3
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
payloads/libpayload/curses/PDCurses/pdcurses/addch.c
View File

@ -173,8 +173,10 @@ int waddch(WINDOW *win, const chtype ch)
/* don't back over left margin */ /* don't back over left margin */
if (--x < 0) if (--x < 0)
case '\r':
x = 0; x = 0;
break;
case '\r':
x = 0;
break; break;

2
payloads/libpayload/curses/PDCurses/pdcurses/scanw.c
View File

@ -274,7 +274,7 @@ static int _pdc_vsscanf(const char *buf, const char *fmt, va_list arg_ptr)
NEXT(c); NEXT(c);
goto string; goto string;
} }
/* fall through */ __fallthrough;
default: default:
if (fmt[1] == '-' && fmt[2] if (fmt[1] == '-' && fmt[2]
&& f < (unsigned char)fmt[2]) && f < (unsigned char)fmt[2])

2
payloads/libpayload/drivers/i8042/keyboard.c
View File

@ -578,7 +578,7 @@ int keyboard_getchar(void)
/* vulcan nerve pinch */ /* vulcan nerve pinch */
if ((modifier & KB_MOD_ALT) && reset_handler) if ((modifier & KB_MOD_ALT) && reset_handler)
reset_handler(); reset_handler();
/* fallthrough */ __fallthrough;
default: default:
ret = 0; ret = 0;
} }

4
payloads/libpayload/libc/printf.c
View File

@ -584,7 +584,7 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap)
/* Integer values */ /* Integer values */
case 'P': /* pointer */ case 'P': /* pointer */
flags |= __PRINTF_FLAG_BIGCHARS; flags |= __PRINTF_FLAG_BIGCHARS;
/* fall through */ __fallthrough;
case 'p': case 'p':
flags |= __PRINTF_FLAG_PREFIX; flags |= __PRINTF_FLAG_PREFIX;
base = 16; base = 16;
@ -604,7 +604,7 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap)
break; break;
case 'X': case 'X':
flags |= __PRINTF_FLAG_BIGCHARS; flags |= __PRINTF_FLAG_BIGCHARS;
/* fall through */ __fallthrough;
case 'x': case 'x':
base = 16; base = 16;
break; break;