From 0bb936da9ae2454307a1ffb4c97aa7c822c09a9c Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Tue, 8 Aug 2017 20:31:46 -0600 Subject: [PATCH] lint: update signed-off-by check The current signed-off-by check doesn't really work well as a lint stable test being run by the pre-commit git hook. This test looks at the PREVIOUS commit instead of the staged commit, which works well on the server. In looking for a way to check the staged commit message, I found the commit-msg hook, which is the correct way to check the staged message. - Update the commit message check from a lint-stable test to a lint-extended test. - Add the check for signed-off-by to the commit-msg hook Change-Id: I8be8aef25730d988c7cf1586ae66ecb839d5f756 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/20920 Tested-by: build bot (Jenkins) Reviewed-by: Chris Ching --- util/gitconfig/commit-msg | 5 ++++- ...ble-020-signed-off-by => lint-extended-020-signed-off-by} | 0 2 files changed, 4 insertions(+), 1 deletion(-) rename util/lint/{lint-stable-020-signed-off-by => lint-extended-020-signed-off-by} (100%) diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg index 82f0581ced..2eef752156 100755 --- a/util/gitconfig/commit-msg +++ b/util/gitconfig/commit-msg @@ -169,5 +169,8 @@ _gen_ChangeId() { git hash-object -t commit --stdin } - +if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then + printf "\nError: No Signed-off-by line in the commit message.\n" + exit 1 +fi add_ChangeId diff --git a/util/lint/lint-stable-020-signed-off-by b/util/lint/lint-extended-020-signed-off-by similarity index 100% rename from util/lint/lint-stable-020-signed-off-by rename to util/lint/lint-extended-020-signed-off-by