GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Update comment 

Expand a comment with additional information, and split it in two lines.

Change-Id: I10389a1a575833c8ecc9a79a374c1816000f5667
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Angel Pons 2020-03-22 12:49:27 +01:00 committed by Patrick Georgi
parent a38fee31b5
commit 0c3936e41b
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/northbridge/intel/sandybridge/raminit_common.c
View File

@ -2501,7 +2501,10 @@ int discover_edges(ramctr_timing *ctrl)
MCHBAR32(IOSAV_DATA_CTL_ch(channel)) = 0; MCHBAR32(IOSAV_DATA_CTL_ch(channel)) = 0;
} }
/* FIXME: under some conditions (older chipsets?) vendor BIOS sets both edges to the same value. */ /*
* FIXME: Under some conditions, vendor BIOS sets both edges to the same value. It will
* also use a single loop. It would seem that it is a debugging configuration.
*/
MCHBAR32(IOSAV_DC_MASK) = 0x300; MCHBAR32(IOSAV_DC_MASK) = 0x300;
printram("discover falling edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x300); printram("discover falling edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x300);