GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode 

As per Intel doc #729124 Section 3.6.1 "Intel CSME Production Machine
Determination", from ADL onwards there are three criteria which
determine whether a device is in production mode:
1. Fuses are programmed
2. SPI descriptor is locked
3. Manufacturing variables are locked

When logging whether the device is in manufacturing mode, #1 and #2 are
already checked. Add a check for #3 as well.

TEST=Build and boot MTL RVP

Snippet from coreboot log:
[DEBUG]  ME: Manufacturing Mode          : YES

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I495a7d8730716fc92e8c57b2caef73e8bb44d30b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69578
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Jamie Ryu <jamie.m.ryu@intel.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
This commit is contained in:
Sridhar Siricilla 2022-11-14 17:25:37 +05:30 committed by Eric Lai
parent 026f86ba3b
commit 0c923732dd
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/soc/intel/meteorlake/me.c
View File

@ -76,6 +76,18 @@ union me_hfsts6 {
} __packed fields;
};
/*
* Manufacturing mode is disabled if the descriptor is locked, fuses
* are programmed and manufacturing variables are locked.
* The function returns true if manufacturing mode is disabled otherwise false.
*/
static bool is_eom(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
{
return (hfsts1.fields.mfg_mode == 0) && (hfsts6.fields.manuf_lock == 1) &&
(hfsts6.fields.fpf_soc_lock == 1);
}
static void dump_me_status(void *unused)
{
union me_hfsts1 hfsts1;
@ -102,13 +114,9 @@ static void dump_me_status(void *unused)
printk(BIOS_DEBUG, "ME: HFSTS5 : 0x%08X\n", hfsts5.data);
printk(BIOS_DEBUG, "ME: HFSTS6 : 0x%08X\n", hfsts6.data);
/*
* Lock Descriptor, and Fuses must be programmed on a
* production system to indicate ME Manufacturing mode is disabled.
*/
printk(BIOS_DEBUG, "ME: Manufacturing Mode : %s\n",
((hfsts1.fields.mfg_mode == 0) &&
(hfsts6.fields.fpf_soc_lock == 1)) ? "NO" : "YES");
is_eom(hfsts1, hfsts6) ? "NO" : "YES");
/*
* The SPI Protection Mode bit reflects SPI descriptor
* locked(0) or unlocked(1).