GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/common/block: Fix issue found by klockwork 

src/soc/intel/common/block/pmc/pmclib.c
  Function acpi_get_sleep_type: Pointer ps checked for
  NULL may be dereferenced.

BRANCH=None
TEST=Built & booted Yorp board.

Change-Id: I15fe39fd9f930be56d03c2ffe62fb6f17249d4b5
Signed-off-by: John Zhao <john.zhao@intel.com>
Reviewed-on: https://review.coreboot.org/29149
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
John Zhao 2018-10-16 10:48:00 -07:00 committed by Patrick Georgi
parent 9b7ae2f3fc
commit 0ccfc0cc53
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/block/pmc/pmclib.c
View File

@ -95,9 +95,13 @@ __weak void pmc_soc_restore_power_failure(void)
int acpi_get_sleep_type(void) int acpi_get_sleep_type(void)
{ {
struct chipset_power_state *ps; struct chipset_power_state *ps;
int prev_sleep_state = ACPI_S0;
ps = pmc_get_power_state(); ps = pmc_get_power_state();
return ps->prev_sleep_state; if (ps)
prev_sleep_state = ps->prev_sleep_state;
return prev_sleep_state;
} }
static uint32_t pmc_reset_smi_status(void) static uint32_t pmc_reset_smi_status(void)