Drop many cases of CONFIG_MAINBOARD_PART_NUMBER

We have largely dropped from filling in mainboard_ops.name
as unnecessary. A common place should be decided where or if
this information is added in the console log.

Change-Id: I917222922560c6273b4be91cd7d99ce2ff8e4231
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74450
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Kyösti Mälkki 2022-12-15 22:12:29 +02:00 committed by Matt DeVillier
parent 10e928319d
commit 0d1734eea4
7 changed files with 0 additions and 10 deletions

View File

@ -159,6 +159,5 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };

View File

@ -58,6 +58,5 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };

View File

@ -69,6 +69,5 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };

View File

@ -179,8 +179,6 @@ static void mainboard_fill_ssdt(const struct device *dev)
static void mainboard_enable(struct device *dev) static void mainboard_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt;
/* TODO: b/184678786 - Move into espi_config */ /* TODO: b/184678786 - Move into espi_config */

View File

@ -173,6 +173,5 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };

View File

@ -78,8 +78,6 @@ static void mainboard_init(void *chip_info)
static void mainboard_enable(struct device *dev) static void mainboard_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
/* TODO: b/184678786 - Move into espi_config */ /* TODO: b/184678786 - Move into espi_config */
/* Unmask eSPI IRQ 1 (Keyboard) */ /* Unmask eSPI IRQ 1 (Keyboard) */
pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));

View File

@ -89,8 +89,6 @@ static void mainboard_init(void *chip_info)
static void mainboard_enable(struct device *dev) static void mainboard_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
/* TODO: b/184678786 - Move into espi_config */ /* TODO: b/184678786 - Move into espi_config */
/* Unmask eSPI IRQ 1 (Keyboard) */ /* Unmask eSPI IRQ 1 (Keyboard) */
pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));