GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mptable: bring sanity back to mptable generation (TRIVIAL) 

Remove extra semicolon
Capitalize beginning of printk sentence
Fix detection of multiple ISA-carrying  IOAPICs
Fix whitespace issue

Change-Id: I114119b1daf3b472955c0dd00bdc449401789525
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/1474
Tested-by: build bot (Jenkins)
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
This commit is contained in:
Alexandru Gagniuc 2012-08-21 17:08:03 -05:00 committed by Anton Kochkov
parent 0013bbfa98
commit 0d5d70b79a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/arch/x86/boot/mpspec.c
View File

@ -426,7 +426,7 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
mptable_init(mc, LOCAL_APIC_ADDR); mptable_init(mc, LOCAL_APIC_ADDR);
smp_write_processors(mc); smp_write_processors(mc);
mptable_write_buses(mc, NULL, &isa_bus); mptable_write_buses(mc, NULL, &isa_bus);
@ -443,16 +443,16 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
ioapic_config->base); ioapic_config->base);
if (ioapic_config->have_isa_interrupts) { if (ioapic_config->have_isa_interrupts) {
if (isaioapic > 1) if (isaioapic >= 0)
printk(BIOS_ERR, "More than one IOAPIC with ISA interrupts?\n"); printk(BIOS_ERR, "More than one IOAPIC with ISA interrupts?\n");
else else
isaioapic = dev->path.ioapic.ioapic_id;; isaioapic = dev->path.ioapic.ioapic_id;
} }
} }
if (isaioapic >= 0) { if (isaioapic >= 0) {
/* Legacy Interrupts */ /* Legacy Interrupts */
printk(BIOS_DEBUG, "writing ISA IRQs\n"); printk(BIOS_DEBUG, "Writing ISA IRQs\n");
mptable_add_isa_interrupts(mc, isa_bus, isaioapic, 0); mptable_add_isa_interrupts(mc, isa_bus, isaioapic, 0);
} }