GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google: Fix wedging AP on early ec sw sync 

If the EC doesn't support the EARLY_EC_SYNC we don't properly set power
limits to reasonable defaults and can wedge the AP by browning out at
the end of vboot.

BRANCH=none
BUG=b:146165519
TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I4e683e5a1c5b453b3742a12a519cad9069e8b7f7
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37930
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tim Wawrzynczak 2019-12-25 19:14:30 +11:00 committed by Patrick Georgi
parent f07d7dc2fd
commit 0d9fb55ae2
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/ec/google/chromeec/ec.c
View File

@ -757,12 +757,17 @@ int google_chromeec_read_limit_power_request(int *limit_power)
.cmd_data_out = &resp,
.cmd_dev_index = 0,
};
int rv;
if (google_chromeec_command(&cmd))
return -1;
rv = google_chromeec_command(&cmd);
if (rv == -EC_RES_INVALID_PARAM || rv == -EC_RES_INVALID_COMMAND) {
printk(BIOS_INFO, "PARAM_LIMIT_POWER not supported by EC.\n");
*limit_power = 0;
return 0;
}
*limit_power = resp.get_param.value;
return 0;
return rv;
}
int google_chromeec_get_protocol_info(