GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/gma.c: Remove useless if condition 

There's a useless check with both branches doing the same: enabling RC6
and disabling RC6p. In past, this condition would enable RC6p in IVB but
not on SNB. Then, at some point, RC6p was considered unstable and was
disabled, but the condition remained.

It's not needed so let's remove it.

Change-Id: I926bb682d1b9d21185048224490b966c33204b6a
Signed-off-by: Evgeny Zinoviev <me@ch1p.io>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42410
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Evgeny Zinoviev 2020-06-16 03:53:37 +03:00 committed by Patrick Georgi
parent d8b4ea992b
commit 0df0c7e359
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/northbridge/intel/sandybridge/gma.c
View File

@ -453,18 +453,15 @@ static void gma_pm_init_pre_vbios(struct device *dev)
gtt_write(0xa06c, 0x000493e0); /* RP Down EI */ gtt_write(0xa06c, 0x000493e0); /* RP Down EI */
gtt_write(0xa070, 0x0000000a); /* RP Idle Hysteresis */ gtt_write(0xa070, 0x0000000a); /* RP Idle Hysteresis */
/* 11a: Enable Render Standby (RC6) */
if ((bridge_silicon_revision() & BASE_REV_MASK) == BASE_REV_IVB) {
/* /*
* 11a: Enable Render Standby (RC6)
*
* IvyBridge should also support DeepRenderStandby. * IvyBridge should also support DeepRenderStandby.
* *
* Unfortunately it does not work reliably on all SKUs so * Unfortunately it does not work reliably on all SKUs so
* disable it here and it can be enabled by the kernel. * disable it here and it can be enabled by the kernel.
*/ */
gtt_write(0xa090, 0x88040000); /* HW RC Control */ gtt_write(0xa090, 0x88040000); /* HW RC Control */
} else {
gtt_write(0xa090, 0x88040000); /* HW RC Control */
}
/* 12: Normal Frequency Request */ /* 12: Normal Frequency Request */
/* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 */ /* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 */