From 0e1be046acaf5cfb9e2c41521270d137fa3423c5 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Mon, 13 Mar 2023 13:41:43 -0700 Subject: [PATCH] soc/intel/cmn/cse: Make heci_(send|receive) public functions Having these two functions public allow "asynchronous" HECI command implementation. Typically, these function can be use to implement an asynchronous End-Of-Post. BUG=b:268546941 BRANCH=firmware-brya-14505.B TEST=Successful compilation for brya0 Change-Id: I7d029bb9af4b53f219018e459d17df9c1bd33fc1 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/73710 Tested-by: build bot (Jenkins) Reviewed-by: Tarun Tuli Reviewed-by: Nick Vaccaro --- src/soc/intel/common/block/cse/cse.c | 17 ++--------------- .../common/block/include/intelblocks/cse.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 25a04ed304..9902094180 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -422,12 +422,7 @@ send_one_message(uint32_t hdr, const void *buff) return pend_len; } -/* - * Send message msg of size len to host from host_addr to cse_addr. - * Returns CSE_TX_RX_SUCCESS on success and other enum values on failure scenarios. - * Also, in case of errors, heci_reset() is triggered. - */ -static enum cse_tx_rx_status +enum cse_tx_rx_status heci_send(const void *msg, size_t len, uint8_t host_addr, uint8_t client_addr) { uint8_t retry; @@ -532,15 +527,7 @@ recv_one_message(uint32_t *hdr, void *buff, size_t maxlen, size_t *recv_len) return CSE_TX_RX_SUCCESS; } -/* - * Receive message into buff not exceeding maxlen. Message is considered - * successfully received if a 'complete' indication is read from ME side - * and there was enough space in the buffer to fit that message. maxlen - * is updated with size of message that was received. - * Returns CSE_TX_RX_SUCCESS on success and other enum values on failure scenarios. - * Also, in case of errors, heci_reset() is triggered. - */ -static enum cse_tx_rx_status heci_receive(void *buff, size_t *maxlen) +enum cse_tx_rx_status heci_receive(void *buff, size_t *maxlen) { uint8_t retry; size_t left, received; diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index 4634984756..c87946ffec 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -344,6 +344,24 @@ void cse_init(uintptr_t bar); /* Initialize the HECI devices. */ void heci_init(void); +/* + * Send message msg of size len to host from host_addr to cse_addr. + * Returns CSE_TX_RX_SUCCESS on success and other enum values on failure scenarios. + * Also, in case of errors, heci_reset() is triggered. + */ +enum cse_tx_rx_status heci_send(const void *msg, size_t len, uint8_t host_addr, + uint8_t client_addr); + +/* + * Receive message into buff not exceeding maxlen. Message is considered + * successfully received if a 'complete' indication is read from ME side + * and there was enough space in the buffer to fit that message. maxlen + * is updated with size of message that was received. + * Returns CSE_TX_RX_SUCCESS on success and other enum values on failure scenarios. + * Also, in case of errors, heci_reset() is triggered. + */ +enum cse_tx_rx_status heci_receive(void *buff, size_t *maxlen); + /* * Send message from BIOS_HOST_ADDR to cse_addr. * Sends snd_msg of size snd_sz, and reads message into buffer pointed by