GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/agah: Remove variant_fill_ssdt() 

Since the GPU will be left powered on, the kernel has the opportunity to
save context and this method to save the BARs is not required.

BUG=b:233959099, b:236289930
TEST=build

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I19cf12426361a53e3672c1e05aa6d68d5dd6627c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65208
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Robert Zieba <robertzieba@google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Tim Wawrzynczak 2022-06-17 10:50:47 -06:00 committed by Felix Held
parent eabd97020e
commit 0e582862c8
1 changed files with 0 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
src/mainboard/google/brya/variants/agah/variant.c
View File

@ -137,64 +137,3 @@ void variant_init(void)
dgpu_power_sequence_on(); dgpu_power_sequence_on();
} }
/* Save PCI BARs to the ACPI copy of the "saved PCI config space" */
void variant_fill_ssdt(const struct device *unused)
{
if (!gpu_powered_on)
return;
const struct device *dgpu = DEV_PTR(dgpu);
acpigen_write_scope("\\_SB.PCI0.PEG0.PEGP");
acpigen_write_method("_INI", 0);
{
/* Local0 = VGAR */
acpigen_write_store();
acpigen_emit_namestring("VGAR");
acpigen_emit_byte(LOCAL0_OP);
/*
* CreateDWordField(Local0, 11, BAR0)
* BAR0 = bases[0]
* CreateDWordField(Local0, 15, BAR1)
* BAR1 = bases[1]
* ...
*/
unsigned int idx, i = 0;
for (idx = PCI_BASE_ADDRESS_0; idx <= PCI_BASE_ADDRESS_5; idx += 4, ++i) {
char name[ACPI_NAME_BUFFER_SIZE];
const struct resource *res;
res = probe_resource(dgpu, idx);
if (!res || !(res->flags & IORESOURCE_STORED))
continue;
snprintf(name, sizeof(name), "BAR%1d", i);
acpigen_write_create_dword_field(LOCAL0_OP, idx - VGAR_BYTE_OFFSET,
name);
acpigen_write_store_int_to_namestr(res->base & 0xffffffff, name);
printk(BIOS_INFO, "GPU: saving %s as 0x%x\n", name,
(uint32_t)(res->base & 0xffffffff));
/* Also save the upper 32 bits of the BAR if applicable */
if (!(res->flags & IORESOURCE_PCI64))
continue;
idx += sizeof(uint32_t);
i++;
snprintf(name, sizeof(name), "BAR%1d", i);
acpigen_write_create_dword_field(LOCAL0_OP, idx - VGAR_BYTE_OFFSET,
name);
acpigen_write_store_int_to_namestr((res->base >> 32) & 0xffffffff,
name);
printk(BIOS_INFO, "GPU: saving %s as 0x%x\n", name,
(uint32_t)((res->base >> 32) & 0xffffffff));
}
/* VGAR = Local0 */
acpigen_write_store_op_to_namestr(LOCAL0_OP, "VGAR");
}
acpigen_write_method_end();
acpigen_write_scope_end();
}