From 0f058f68a24643acfca7fb5825ddbab19ff732c3 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 5 Dec 2020 01:29:38 +0100 Subject: [PATCH] soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops Now pci_domain_ops in chip.c can also be marked as static. Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/48315 Reviewed-by: Furquan Shaikh Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/soc/amd/picasso/chip.c | 2 +- src/soc/amd/picasso/chip.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c index 83845416a4..d31e94a277 100644 --- a/src/soc/amd/picasso/chip.c +++ b/src/soc/amd/picasso/chip.c @@ -55,7 +55,7 @@ const char *soc_acpi_name(const struct device *dev) return NULL; }; -struct device_operations pci_domain_ops = { +static struct device_operations pci_domain_ops = { .read_resources = pci_domain_read_resources, .set_resources = pci_domain_set_resources, .scan_bus = pci_domain_scan_bus, diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 28d2040968..412cc087b1 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -223,6 +223,4 @@ struct soc_amd_picasso_config { typedef struct soc_amd_picasso_config config_t; -extern struct device_operations pci_domain_ops; - #endif /* __PICASSO_CHIP_H__ */