Build system: Remove IASL_WARNINGS_ARE_ERRORS option
All systems are building with IASL warnings as errors enabled. Remove the option to disable it. Remove the notification at the end of the build. Change-Id: I5c6218c182fdf173b4026fd010d939a5fa36040e Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/16606 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
parent
66c2c1a2d4
commit
0f671f6ee9
|
@ -238,11 +238,7 @@ cbfs-files-$(if $(2),$(2),y) += $(CONFIG_CBFS_PREFIX)/$(1).aml
|
|||
$(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h
|
||||
@printf " IASL $$(subst $(top)/,,$$(@))\n"
|
||||
$(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@
|
||||
ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y)
|
||||
cd $$(dir $$@); $(IASL) -we -p $$(notdir $$@) $$(notdir $$@)
|
||||
else
|
||||
cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@)
|
||||
endif
|
||||
if [ -z "$$$$($(IASL) -d $$@ 2>&1 | grep 'ACPI Warning')" ]; then echo " IASL $$@ disassembled correctly."; true; else echo "Error: Could not correctly disassemble $$@"; $(IASL) -d $$@; false; fi
|
||||
endef
|
||||
|
||||
|
@ -895,10 +891,6 @@ endif
|
|||
mv $@.tmp $@
|
||||
@printf " CBFSPRINT $(subst $(obj)/,,$(@))\n\n"
|
||||
$(CBFSTOOL) $@ print -r $(subst $(spc),$(comma),$(all-regions))
|
||||
ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),)
|
||||
@printf "\n***** WARNING: IASL warnings as errors is disabled! *****\n"
|
||||
@printf "***** Please fix the ASL for this platform. *****\n\n"
|
||||
endif
|
||||
|
||||
cbfs-files-y += $(CONFIG_CBFS_PREFIX)/romstage
|
||||
$(CONFIG_CBFS_PREFIX)/romstage-file := $(objcbfs)/romstage.elf
|
||||
|
|
13
src/Kconfig
13
src/Kconfig
|
@ -1146,19 +1146,6 @@ config WARNINGS_ARE_ERRORS
|
|||
bool
|
||||
default y
|
||||
|
||||
# TODO: Remove this when all platforms are fixed.
|
||||
config IASL_WARNINGS_ARE_ERRORS
|
||||
def_bool y
|
||||
help
|
||||
Select to Fail the build if a IASL generates a warning.
|
||||
This will be defaulted to disabled for the platforms that
|
||||
currently fail. This allows the REST of the platforms to
|
||||
have this check enabled while we're working to get those
|
||||
boards fixed.
|
||||
|
||||
DO NOT ADD TO ANY ADDITIONAL PLATFORMS INSTEAD OF FIXING
|
||||
THE ASL.
|
||||
|
||||
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
|
||||
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are
|
||||
# mutually exclusive. One of these options must be selected in the
|
||||
|
|
Loading…
Reference in New Issue