From 0f8436cc91291c29d767489c1f5e92850d198519 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Tue, 10 Apr 2018 13:42:03 +0200 Subject: [PATCH] sb/intel/i82801gx: Clean up unneeded smi setup code All i82801gx targets now use SMM_TSEG. Change-Id: Ib4e6974088a685290ed1dddf5228a99918744124 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/25599 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Felix Held --- src/cpu/x86/smm/smmrelocate.S | 4 +--- src/southbridge/intel/i82801gx/Makefile.inc | 4 ---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/cpu/x86/smm/smmrelocate.S b/src/cpu/x86/smm/smmrelocate.S index bd12581a76..fa49def1ad 100644 --- a/src/cpu/x86/smm/smmrelocate.S +++ b/src/cpu/x86/smm/smmrelocate.S @@ -21,9 +21,7 @@ // can it be cleaned up so this include is not required? // It's needed right now because we get our DEFAULT_PMBASE from // here. -#if IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX) -#include -#elif IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801DX) +#if IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801DX) #include #elif IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801IX) #include diff --git a/src/southbridge/intel/i82801gx/Makefile.inc b/src/southbridge/intel/i82801gx/Makefile.inc index 606afda3fe..290794b08d 100644 --- a/src/southbridge/intel/i82801gx/Makefile.inc +++ b/src/southbridge/intel/i82801gx/Makefile.inc @@ -32,10 +32,6 @@ ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c ramstage-y += watchdog.c -ifneq ($(CONFIG_SMM_TSEG),y) -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S -endif smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c romstage-y += early_smbus.c early_lpc.c