GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google: Fix log messages 

Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'.

Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Elyes Haouas 2022-11-13 07:34:48 +01:00 committed by Martin L Roth
parent 8f692f41bf
commit 0f864f6ef9
6 changed files with 13 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/auron/variants/buddy/variant.c
View File

@ -55,8 +55,7 @@ static unsigned char get_hex_digit(u8 *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset);
*offset, *offset);
retval = 0; retval = 0;
} }
@ -72,8 +71,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, search_address, sizeof(key) - 1, search_length); offset = search(key, search_address, sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);

6
src/mainboard/google/beltino/lan.c
View File

@ -36,8 +36,7 @@ static unsigned char get_hex_digit(u8 *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset);
*offset, *offset);
retval = 0; retval = 0;
} }
@ -53,8 +52,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, search_address, sizeof(key) - 1, search_length); offset = search(key, search_address, sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);

7
src/mainboard/google/butterfly/mainboard.c
View File

@ -40,7 +40,7 @@ static unsigned char get_hex_digit(char *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n",
*offset, (unsigned char)*offset); *offset, (unsigned char)*offset);
retval = 0; retval = 0;
} }
@ -58,8 +58,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, (char *)search_address, offset = search(key, (char *)search_address,
sizeof(key) - 1, search_length); sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);
@ -149,7 +148,7 @@ static void program_keyboard_type(u32 search_address, u32 search_length)
kbd_type = EC_KBD_JP; kbd_type = EC_KBD_JP;
} }
} else { } else {
printk(BIOS_DEBUG, "Error: Could not locate VPD area\n"); printk(BIOS_ERR, "Could not locate VPD area\n");
} }
printk(BIOS_DEBUG, "Setting Keyboard type in EC to "); printk(BIOS_DEBUG, "Setting Keyboard type in EC to ");

6
src/mainboard/google/jecht/lan.c
View File

@ -36,8 +36,7 @@ static unsigned char get_hex_digit(u8 *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset);
*offset, *offset);
retval = 0; retval = 0;
} }
@ -53,8 +52,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, search_address, sizeof(key) - 1, search_length); offset = search(key, search_address, sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);

6
src/mainboard/google/rambi/variants/ninja/lan.c
View File

@ -35,8 +35,7 @@ static unsigned char get_hex_digit(u8 *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset);
*offset, *offset);
retval = 0; retval = 0;
} }
@ -52,8 +51,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, search_address, sizeof(key) - 1, search_length); offset = search(key, search_address, sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);

6
src/mainboard/google/rambi/variants/sumo/lan.c
View File

@ -35,8 +35,7 @@ static unsigned char get_hex_digit(u8 *offset)
retval = *offset - 'a' + 0x0a; retval = *offset - 'a' + 0x0a;
} }
if (retval > 0x0F) { if (retval > 0x0F) {
printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset);
*offset, *offset);
retval = 0; retval = 0;
} }
@ -52,8 +51,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword,
offset = search(key, search_address, sizeof(key) - 1, search_length); offset = search(key, search_address, sizeof(key) - 1, search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_DEBUG, printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key);
"Error: Could not locate '%s' in VPD\n", key);
return 0; return 0;
} }
printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);