From 101485c73dbb7eb8d89fbfda1c1bf9a5e495b536 Mon Sep 17 00:00:00 2001 From: Alex Thiessen Date: Sat, 13 Jan 2018 19:49:33 +0000 Subject: [PATCH] util/gitconfig: Replace printf with heredoc The `gitconfig.sh` script contains a call to `printf` with a lengthy argument where no format string is used at all. Replace it with a heredoc for better readability. Change-Id: I42dbaa570ab9661991fa5d9b4577c9aed05c2981 Signed-off-by: Alex Thiessen Reviewed-on: https://review.coreboot.org/23251 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- util/gitconfig/gitconfig.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index edfb6df742..5d6fe3610b 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -65,7 +65,10 @@ git submodule update --init --checkout" { git config --includes user.name && \ git config --includes user.email; } >/dev/null || \ - { printf "Please configure your name and email in git:\n\n\ - git config --global user.name \"Your Name Comes Here\"\n\ - git config --global user.email your.email@example.com\n"; \ + { cat <<-EOMSG + Please configure your name and email in git: + + git config --global user.name "Your Name Comes Here" + git config --global user.email your.email@example.com +EOMSG exit 1; }