From 10817c7d5a4408487fe208370539fe8c24cb83b1 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 16 Oct 2022 13:56:30 -0500 Subject: [PATCH] mb/google/glados: Fix WiFi SAR options SAR-related Kconfigs are only used by ChromeOS, and should be guarded properly as such (as most other boards do). TEST=build glados w/o CONFIG_CHROMEOS, verify SAR-related Kconfigs not selected. Change-Id: Id8abf68ed2e9720b5580f7965208dbe36460af07 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/68458 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/mainboard/google/glados/Kconfig | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index ff6b1ea862..631d90d1f3 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -31,12 +31,10 @@ config BOARD_GOOGLE_ASUKA config BOARD_GOOGLE_CAROLINE select BOARD_GOOGLE_BASEBOARD_GLADOS - select DSAR_ENABLE + select CHROMEOS_WIFI_SAR if CHROMEOS select INTEL_GMA_HAVE_VBT select MAINBOARD_NO_FSP_GOP select NHLT_SSM4567 if INCLUDE_NHLT_BLOBS - select SAR_ENABLE - select USE_SAR config BOARD_GOOGLE_CAVE select BOARD_GOOGLE_BASEBOARD_GLADOS @@ -75,6 +73,13 @@ config BOARD_GOOGLE_SENTRY if BOARD_GOOGLE_BASEBOARD_GLADOS +config CHROMEOS_WIFI_SAR + bool "Enable SAR options for ChromeOS build" + depends on CHROMEOS + select DSAR_ENABLE + select SAR_ENABLE + select USE_SAR + config DISABLE_HECI1_AT_PRE_BOOT default y