From 10a500eb324f0deea0bc9bf89e9f7bb185fcd05a Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Sat, 30 Apr 2022 08:45:44 +0200 Subject: [PATCH] mb/biostar/a68n_5200: Use pci_or_config8() Change-Id: I4be0a4ad980b4167eaaafc22399b680abf011553 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/63971 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/mainboard/biostar/a68n_5200/bootblock.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/mainboard/biostar/a68n_5200/bootblock.c b/src/mainboard/biostar/a68n_5200/bootblock.c index 70bc10c743..5920199775 100644 --- a/src/mainboard/biostar/a68n_5200/bootblock.c +++ b/src/mainboard/biostar/a68n_5200/bootblock.c @@ -28,8 +28,6 @@ static void sbxxx_enable_48mhzout(void) void bootblock_mainboard_early_init(void) { - u8 byte; - /* Enable the AcpiMmio space */ pm_io_write8(0x24, 1); @@ -37,15 +35,11 @@ void bootblock_mainboard_early_init(void) const pci_devfn_t dev = PCI_DEV(0, 0x14, 3); pci_write_config32(dev, 0x44, 0xff03ffd5); - /* enable SIO LPC decode */ - byte = pci_read_config8(dev, 0x48); - byte |= 3; /* 2e, 2f */ - pci_write_config8(dev, 0x48, byte); + /* enable SIO LPC decode at 0x2e/2f */ + pci_or_config8(dev, 0x48, 3); - /* enable serial decode */ - byte = pci_read_config8(dev, 0x44); - byte |= (1 << 6); /* 0x3f8 */ - pci_write_config8(dev, 0x44, byte); + /* enable serial decode at 0x3f8 */ + pci_or_config8(dev, 0x44, 1 << 6); /* enable SIO clock */ sbxxx_enable_48mhzout();