GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: Don't add bits 

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: Id56310bd616cd19fee5dc934676006b2dc34b1ff
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65929
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes Haouas 2022-07-17 10:22:30 +02:00 committed by Patrick Georgi
parent bb5ccbd42f
commit 10cd06b1c7
6 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/amd/inagua/BiosCallOuts.c
View File

@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;

4
src/mainboard/amd/south_station/BiosCallOuts.c
View File

@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;

4
src/mainboard/amd/union_station/BiosCallOuts.c
View File

@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
Data8 |= BIT2 + BIT3;
Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;

2
src/mainboard/ocp/deltalake/ramstage.c
View File

@ -331,7 +331,7 @@ unsigned int smbios_processor_family(struct cpuid_result res)
unsigned int smbios_processor_characteristics(void)
{
/* 64-bit Capable, Multi-Core, Power/Performance Control */
return 0x8c; /* BIT2 + BIT3 + BIT7 */
return 0x8c; /* BIT2 | BIT3 | BIT7 */
}
static void mainboard_enable(struct device *dev)

2
src/soc/amd/common/block/include/amdblocks/aoac.h
View File

@ -10,7 +10,7 @@
#define AOAC_DEV_D3_STATE(device) (AOAC_DEV_D3_CTL(device) + 1)
/* Bit definitions for Device D3 Control AOACx0000[40...7E; even byte addresses] */
#define FCH_AOAC_TARGET_DEVICE_STATE (BIT(0) + BIT(1))
#define FCH_AOAC_TARGET_DEVICE_STATE (BIT(0) | BIT(1))
#define FCH_AOAC_D0_UNINITIALIZED 0
#define FCH_AOAC_D0_INITIALIZED 1
#define FCH_AOAC_D1_2_3_WARM 2

2
src/soc/intel/quark/include/soc/QuarkNcSocId.h
View File

@ -807,7 +807,7 @@
#define B_QNC_RCRB_SPIOPTYPE_NOADD_READ 0
#define B_QNC_RCRB_SPIOPTYPE_NOADD_WRITE (BIT0)
#define B_QNC_RCRB_SPIOPTYPE_ADD_READ (BIT1)
#define B_QNC_RCRB_SPIOPTYPE_ADD_WRITE (BIT0 + BIT1)
#define B_QNC_RCRB_SPIOPTYPE_ADD_WRITE (BIT0 | BIT1)
// Opcode Menu Configuration //R_OPMENU
#define R_QNC_RCRB_SPIOPMENU (R_QNC_RCRB_SPIBASE + 0x58)