From 10ee7fc03ac38dfabb3190b00db2db66d35f541a Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 21 Dec 2020 17:17:02 -0800 Subject: [PATCH] cbfs: Fix attribute tag printing in cbfs_find_attr() Attribute tags are defined as hexadecimal constants, not decimal, so it makes more sense to print them like that in error messages as well. Signed-off-by: Julius Werner Change-Id: I3a5a6a8c9b8d24e57633595fc47221a483d8593a Reviewed-on: https://review.coreboot.org/c/coreboot/+/48836 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Aaron Durbin --- src/commonlib/bsd/cbfs_private.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/commonlib/bsd/cbfs_private.c b/src/commonlib/bsd/cbfs_private.c index 527860db75..91f81e0db4 100644 --- a/src/commonlib/bsd/cbfs_private.c +++ b/src/commonlib/bsd/cbfs_private.c @@ -173,13 +173,13 @@ const void *cbfs_find_attr(const union cbfs_mdata *mdata, uint32_t attr_tag, siz const uint32_t len = be32toh(attr->len); if (offset + len > end) { - ERROR("Attribute %s[%u] overflows end of metadata\n", + ERROR("Attribute %s[%x] overflows end of metadata\n", mdata->h.filename, tag); return NULL; } if (tag == attr_tag) { if (size_check && len != size_check) { - ERROR("Attribute %s[%u] size mismatch: %u != %zu\n", + ERROR("Attribute %s[%x] size mismatch: %u != %zu\n", mdata->h.filename, tag, len, size_check); return NULL; }