GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

drivers/amd/i2s_machine_dev: return if scope is NULL

Browse source 
Avoid dereferencing a null pointer.

Found-by: Coverity CID 1430549
BUG=None
TEST=Build

Signed-off-by: Martin Roth <martin@coreboot.org>
Change-Id: I53f6a38aac6e7f94c3c370996b3b82ca0d88dac4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44001
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Martin Roth 2020-07-28 09:42:07 -06:00 committed by Patrick Georgi
parent 6880aec670
commit 114cf22e8d
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
View file

@ -21,6 +21,11 @@ static void i2s_machine_dev_fill_ssdt(const struct device *dev)
dmic_select_gpio = &cfg->dmic_select_gpio;
if (scope == NULL) {
printk(BIOS_ERR, "%s: ERROR: ACPI I2S scope not found\n", dev_path(dev));
return;
}
if (cfg->hid == NULL) {
printk(BIOS_ERR, "%s: ERROR: HID required\n", dev_path(dev));
return;